fix(chunks): guard views/chunks for Apache 2.4 and build the store without bootstrap constants - #2468
Merged
Conversation
…thout bootstrap constants views/chunks/.htaccess and the guard ChunkFileStore writes were Apache 2.2 only, which ApacheConfigHardeningTest refuses. ChunkFileStore::make() also read EVO_BASE_PATH unconditionally, so the cache refresh worker (and any other process without the bootstrap) died in Cache::buildCache(). Both broke CI on 3.5.x once evolution-cms#2447 merged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
3.5.xhas been red since #2447 merged (Unit tests (PHP 8.3)and(PHP 8.4)on every run aftera305e02ba), with two failures that never showed on the PR itself because the tests were added to3.5.xafter that branch was cut:ApacheConfigHardeningTest—views/chunks/.htaccess(and the guardChunkFileStore::ensureDirectory()writes) used the Apache 2.2 dialect only, which is a 500 on 2.4 withoutmod_access_compat. Both now carry the<IfModule mod_authz_core.c>/<IfModule !mod_authz_core.c>pair like every other shipped.htaccess.CacheDocumentRefreshTest—ChunkFileStore::make()readEVO_BASE_PATHunconditionally, so the cache refresh worker (a process without the bootstrap) died inCache::buildCache().make()anddisplayDirectory()now go through abasePath()helper that falls back to the installation root.Test plan
ChunkFileStoreGuardsTestpins both: the written guard matches the shipped file and has no bare 2.2 directive, and a fresh PHP process without the constants resolvesviews/chunks/composer analyze— no errors🤖 Generated with Claude Code