Repository navigation
Precompute block line markers per line, not per character - #449
Open
John-Cusack wants to merge 2 commits into
Open
John-Cusack wants to merge 2 commits into
John-Cusack wants to merge 2 commits into
Conversation
John-Cusack
added a commit
to John-Cusack/rustsmith
that referenced
this pull request
Oct 14, 2026
…ecutablebooks/markdown-it-py#449) (#77) Co-authored-by: crewmate <crewmate@local>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StateBlock.__init__built its line markers (bMarks/eMarks/tShift/sCount/bsCount) by dispatching every source character through a Python-level loop (enumerate+isStrSpacecall per char, plus a branch per char for the rest of the line). This patch builds the identical markers once per line:str.findlocates each\nat C speed and only leading whitespace is scanned (usually zero iterations). The scan body (space/tab counting with tab-stop expansion) is unchanged, so the recorded markers are exactly the same.Single file changed:
markdown_it/rules_block/state_block.py(+29/-29). No parsing logic touched, no new dependency, no behavior change.Correctness
1031 passed, 1 skipped— identical counts tomaster(6f58654) in the same environment.tests/fixtures aside, rendered output compared over a 16.7KB mixed document, a 280KB bulk document, and 30 edge inputs (empty, lone\n, CRLF, lone CR, tabs, deep indents, 10KB single line, 20K-line list, entities, emoji, tables, fences) ×default/commonmark/zeropresets — 0 divergences.ruff checkandblack --checkclean on the changed file.Performance
Frozen workload below (self-contained repro script, stdlib + installed
markdown-it-pyonly, seed-fixed; run it under each tree). Best of 6 interleaved fresh-process rounds, CPython 3.12.3, Linux:Memory (tracemalloc peak over the repro workload):
1200469 Bon both sides — neutral, as expected (same lists, same lengths).Reproduction
Checklist
pytest tests/: 1031 passed, 1 skipped, same as master)ruff check,black --checkclean)