Skip to content

Add test CI for configlet fetching - #266

Merged
glennj merged 2 commits into
exercism:mainfrom
BNAndras:add-configlet-fetch-ci
Oct 17, 2026
Merged

glennj merged 2 commits into
exercism:mainfrom
BNAndras:add-configlet-fetch-ci

Conversation

@BNAndras

Copy link
Copy Markdown
Member

Closes #108

@BNAndras BNAndras added x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:rep/tiny Tiny amount of reputation labels Oct 17, 2026
Comment thread .github/workflows/test-configlet-ci.yml Outdated
@IsaacG

IsaacG commented Oct 17, 2026

Copy link
Copy Markdown
Member

What's the purpose of this CI? What purpose does it serve?

Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
@BNAndras

Copy link
Copy Markdown
Member Author

It tests if the configlet reusable workflow can fetch configlet. The configlet repo itself checks whether configlet can be fetched, but nothing is testing if this workflow works.

@kotp kotp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test relies on the response code for the option --version. This relies on someone not deciding that it should exit with signal other than 0.

It might be enough, but we might check for something more significant than "command with this name evaluates with a success signal"

@BNAndras

Copy link
Copy Markdown
Member Author

Then the CI fails with a nonzero exit code, and we investigate the breakage to determine whether the issue lies with the workflow or configlet itself.

What more significant test are you proposing? The CI is testing that configlet can be fetched and executed successfully, not to test its functionality. The specific command isn’t particularly important, but checking the version is simple enough.

@glennj

glennj commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

And it's being fetched into a new container. Unlikely there would be any other "configlet" there.

@glennj
glennj merged commit 3058e9d into exercism:main Oct 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:rep/tiny Tiny amount of reputation x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: does not test that this repo's fetch-configlet works

4 participants