swift-scheduling: add test for quarterly rollover off-by-one error#2669
Conversation
Add a test case where the meeting starts in the last month of a quarter (Q2, June 15). Some solutions incorrectly rolled the delivery date over to the following quarter/year, even though the meeting start is still well within the target quarter. This case guards against that off-by-one error.
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
5 participants
Adds a test case for an off-by-one error where solutions incorrectly roll the delivery date to the next quarter/year when the meeting starts in the last month of the target quarter — even though it's still within that quarter.
meetingStart: 2019-06-15T09:50:00 (Q2)
expected deliveryDate: 2019-06-28T08:00:00 (last workday of Q2; June 30 is a Sunday)
Discussed and approved by maintainers here: https://forum.exercism.org/t/proposal-add-a-test-case-for-an-off-by-one-error-at-quarter-boundaries/65308