Repository navigation
feat(logs): add connection and run-by-you filters - #712
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Recent Query Logs page had no filtering, so finding runs for a specific connection or your own runs meant paging through everything. This adds two query-param filters to ListQueryLogView (
connectionandrun_by_me) plus a filter form on the logs page. No new dependencies (plain GET params instead of django-filter) and no log schema changes.Changes
database_connection_idand current user, exposes filter context (connections, selection, querystring)Testing
manage.py test explorer.tests.test_views.TestQueryLog --settings=explorer.tests.settings_base— 8 tests OKmanage.py test explorer --settings=explorer.tests.settings_base— 276 tests, only 2 pre-existing failures unrelated to this change (assistant history ordering and a Windows-path assertion, both fail on clean master too)Related
Fixes #665