Repository navigation
Update frontend dependencies (DOMPurify XSS fixes, Vite 7, Node 22) - #714
Open
chrisclark wants to merge 2 commits into
Open
chrisclark wants to merge 2 commits into
chrisclark wants to merge 2 commits into
Conversation
- npm audit fix: DOMPurify 3.1.3 -> 3.4.16 (XSS advisories; it sanitizes AI Assistant output in the browser bundle), plus nanoid, immutable, postcss, rollup and others. - Vite 5 -> 7, vite-plugin-static-copy 1 -> 4, sass ~1.69 -> ^1.105; removed unused vite-plugin-copy. - vite-plugin-static-copy 4 preserves directory structure, so copied images need rename.stripBase to stay at images/<file>. - Silence Bootstrap 5's Sass deprecation warnings (can't migrate until Bootstrap 6). - Node 20.15.1 -> 22 (.nvmrc, Dockerfile, entrypoint.sh): Vite 7 and static-copy 4 need it, and Node 20 is end-of-life. Remaining audit finding: braces (all versions, no fix) via chokidar, used by vite-plugin-static-copy's dev-mode watcher with fixed globs. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the stale Dependabot PRs #680 and #682.
npm auditgoes from 14 findings (11 high) to 1.Runtime (shipped in the browser bundle)
innerHTML, so these advisories reached end users.npm audit fixwith no range changes.Build tooling
es2015target.rename: { stripBase: true }. Without it, the logo lands atimages/explorer/src/images/logo.pngand breaks on every page.~1.69→^1.105. Bootstrap 5's own Sass triggers Dart Sass deprecation warnings that can't be fixed until Bootstrap 6, so they're silenced invite.config.mjs.vite-plugin-copy, which was unused..nvmrc(CI and PyPI publish), theDockerfileandentrypoint.sh. Vite 7 and static-copy 4 require it, and Node 20 is end-of-life.Remaining finding:
bracesviachokidar. It affects every version and has no fix. It's only reached by static-copy's dev-mode file watcher with our fixed glob patterns.Testing
VITE_DEV_MODE=False). Query list, query view, query with results, playground, new query, logs and connections all load with no console errors and no failed requests. CodeMirror and the schema iframe render, and the images load./assistant/response containing markdown plus<script>,onerrorand ajavascript:link. The markdown renders (heading, bold, code block), all three payloads are stripped, and nothing executes.🤖 Generated with Claude Code