Repository navigation
Declare click as a dependency - #105
Closed
Kayvan-Zahiri wants to merge 1 commit into
Closed
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
weasel/util/config.py imports click directly, but it was only ever installed through typer, and current typer no longer depends on click, so a fresh install fails on import. Same fix spaCy made in #13973.
Author
|
Closing: 3bff77f (v1.0.1) declares |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
weasel/util/config.pyimportsclickdirectly, butclickisn't ininstall_requires. It used to arrive through typer, and current typer (0.27.2) no longer depends on click, so a fresh install can't be imported:This adds
click>=8.0.0tosetup.cfgandrequirements.txt(click.shell_completionneeds 8.0). It's the same fix spaCy made in explosion/spaCy#13973.Tested in a clean Python 3.12 venv:
import weaselfails onmainand works on this branch. Test suite: 54 passed.test_project_assets,test_project_config_interpolation[10_0]andtest_remotefail the same way onmainin the same environment.Types of change
Bug fix (packaging).
Checklist
main.)Written with AI assistance. The runs above are real.