Skip to content

[Repo Assist] [JS/TS] Add regression tests for N0, C0, P0 format specifiers#4450

Draft
github-actions[bot] wants to merge 1 commit into
mainfrom
repo-assist/test-zero-precision-formats-f3aa41904be9487b
Draft

[Repo Assist] [JS/TS] Add regression tests for N0, C0, P0 format specifiers#4450
github-actions[bot] wants to merge 1 commit into
mainfrom
repo-assist/test-zero-precision-formats-f3aa41904be9487b

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

  • Add N0, C0, and P0 test cases to ConvertTests.fs
  • These format specifiers previously had no precision-0 test coverage, leaving a gap that allowed the trailing-dot regressions (e.g. "255." instead of "255", "¤255." instead of "¤255") fixed in Format specifies don't seem to be fully implemented #2582 to go undetected
  • Tests cover int and float types with both positive and negative values

Motivation

The existing ToString format tests cover N2, N15, N (default) but not N0. Likewise for C and P. Adding zero-precision cases ensures the precision-0 branches in String.ts remain correct if refactored.

Test plan

  • ./build.sh test javascript — new test cases pass
  • ./build.sh test typescript — new test cases pass

🤖 Generated with Repo Assist

Note

🔒 Integrity filtering filtered 100 items

Integrity filtering activated and filtered the following items during workflow execution.
This happens when a tool call accesses a resource that does not meet the required integrity or secrecy level of the workflow.

Generated by Repo Assist ·

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f

Add tests to prevent regressions for the trailing-dot bugs in N0, C0,
and P0 numeric format specifiers (related to #2582). These test cases
were previously missing from ConvertTests.fs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added automation Automated changes repo-assist Created by Repo Assist labels Mar 26, 2026
@MangelMaxime MangelMaxime force-pushed the main branch 2 times, most recently from 7ceced2 to c85af32 Compare June 30, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Automated changes repo-assist Created by Repo Assist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants