fix(js/ts): int64 non-decimal parsing and BitConverter .NET mismatches#4748
Open
Thorium wants to merge 1 commit into
Open
fix(js/ts): int64 non-decimal parsing and BitConverter .NET mismatches#4748Thorium wants to merge 1 commit into
Thorium wants to merge 1 commit into
Conversation
- Long.parse never applied two's-complement wrap for hex/octal/binary, returning values outside the int64 range (0xFFFFFFFFFFFFFFFF parsed to 2^64-1 instead of -1); now mirrors Int32's sign-extension via BigInt.asIntN with proper range checks - parse crashed with a raw JS error on negative prefixed input like -0xFF (valid .NET input, expect -255) - BitConverter.toBoolean returned true only for byte 1; .NET treats any nonzero byte as true - BitConverter.toString emitted lowercase hex; .NET is uppercase
dbrattli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(split from #4738)