Repository navigation
Update Node.js version and GitHub Actions to latest versions - #251
Open
MangelMaxime wants to merge 3 commits into
Open
MangelMaxime wants to merge 3 commits into
MangelMaxime wants to merge 3 commits into
Conversation
Dependabot bumps (browserslist #244, @babel/core #249) pulled in node-releases@2.0.57, which requires node >=18. With engine-strict=true, npm install failed with EBADENGINE on the Node 14 / npm 7 runners. Switch CI and Publish to Node 22 (bundled npm), bump checkout/setup-node to v4, and raise the engines.node floor to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014dzXtVc5r3a91n9yGBzit6
Use setup-node's node-version-file so the Node version lives in one place. setup-node reads volta.node first, so pin it there to 22 and keep engines.node as the minimum supported version for local development. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014dzXtVc5r3a91n9yGBzit6
.nvmrc is read by setup-node, nvm, fnm and mise, so it is a more standard single source of truth than a volta field in package.json. Drop the engines field: it mainly kept npm 6 (which would rewrite the v2 lockfile) out, which is no longer relevant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014dzXtVc5r3a91n9yGBzit6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the project's Node.js tooling and CI/CD configuration by upgrading to the latest versions of GitHub Actions and Node.js 22, while simplifying version management through a
.nvmrcfile.Key Changes
checkoutandsetup-node.nvmrcfilenode-version-fileconfiguration in GitHub Actions to read version from.nvmrcpackage.jsonengines fieldpackage-lock.jsonto reflect dependency changesImplementation Details
.nvmrcfile now serves as the single source of truth for the Node.js version across both local development and CI/CD environmentshttps://claude.ai/code/session_014dzXtVc5r3a91n9yGBzit6