Skip to content

Add interpreter finding tests - #4856

Closed
connernilsen wants to merge 2 commits into
facebook:mainfrom
connernilsen:export-D118901054
Closed

connernilsen wants to merge 2 commits into
facebook:mainfrom
connernilsen:export-D118901054

Conversation

@connernilsen

Copy link
Copy Markdown
Contributor

Differential Revision: D118901054

connernilsen and others added 2 commits September 8, 2026 13:16
…facebook#4649)

Summary:
Part two addressing facebook#4306

This should make it so we can get the Pyrefly binary from the environment (and do that by default), as well as update how the selections are made.

Not sure if this is going to be a popular decision, but I made `lspPath` only used when set in the `pyreflyExecutable` setting since that makes testing easier, but that behavior may differ from expectations.


Differential Revision: D117314161

Pulled By: connernilsen
Differential Revision: D118901054
@meta-cla meta-cla Bot added the cla signed label Sep 8, 2026
@meta-codesync

meta-codesync Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@connernilsen has exported this pull request. If you are a Meta employee, you can view the originating Diff in D118901054.

connernilsen added a commit to connernilsen/pyrefly that referenced this pull request Sep 14, 2026
Summary:
Add tests validating the interpreter finder Python script and type checking the VSCode extension.


Differential Revision: D118901054

@kinto0 kinto0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot closed this in 2198823 Sep 16, 2026
@meta-codesync meta-codesync Bot added the Merged label Sep 16, 2026
@meta-codesync

meta-codesync Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

This pull request has been merged in 2198823.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants