feat: let ProxyMethod resolve callable attribute targets - #4915
Open
yeetypete wants to merge 3 commits into
Open
feat: let ProxyMethod resolve callable attribute targets#4915yeetypete wants to merge 3 commits into
yeetypete wants to merge 3 commits into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D119805915. (Because this pull request was imported automatically, there will not be any future comments.) |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let
ProxyMethodresolve a target declared as a class attribute, in addition to an ordinary instance method. A target is accepted whenever pyrefly can call it:Callable[...]annotations, callback protocols, andtype[X]constructors all work but non-callable targets such asforward: intare still rejected.This lets the shape stubs declare
nn.Module.forwardasCallable[..., Any], matching PyTorch:https://github.com/pytorch/pytorch/blob/d6c03540dc0f040e1d8a920d19d9333de6513545/torch/nn/modules/module.py#L526
The stubs previously declared
forwardas a method because that was the only targetProxyMethodcould resolve. Understrict-callable-subtyping, a method-formforward(*args, **kwargs)makes every concreteforward(self, x)override abad-override.Test Plan
Run
test.py.