Remove enableBridgelessArchitecture branches from ReactAndroid simple call sites#56999
Open
mdvacca wants to merge 1 commit into
Open
Remove enableBridgelessArchitecture branches from ReactAndroid simple call sites#56999mdvacca wants to merge 1 commit into
enableBridgelessArchitecture branches from ReactAndroid simple call sites#56999mdvacca wants to merge 1 commit into
Conversation
…le call sites Summary: Second in a stack that collapses Android-side branches on `ReactNativeNewArchitectureFeatureFlags.enableBridgelessArchitecture()` under the standing assumption that on Android the flag is always `true`. The underlying generated `ReactNativeFeatureFlags.enableBridgelessArchitecture()` is untouched. Scope of this commit — ReactAndroid simple call sites: - `DevSupportManagerBase` — drop the flag from the AND chain that gates `PerfMonitorOverlayManager` creation. - `HeadlessJsTaskService.reactContext` getter and `createReactContextAndScheduleTask` — keep the `reactHost` branches; drop the `reactInstanceManager` fallbacks. - `ViewManager.getNativeProps` — drop the flag from the AND with `UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE`. - `ReactImageView` — delete the `warnImageSource` helper and its two call sites. The helper existed only to emit a debug warning that was already gated off in bridgeless mode. - `ReactEditText.onConfigurationChanged` — drop the flag from the AND with `enableFontScaleChangesUpdatingLayout`. - `ReactHostImpl.getOrCreateStartTask` — drop the always-true debug assertion. - `DefaultNewArchitectureEntryPoint.loadWithFeatureFlags` — set `privateBridgelessEnabled = true` directly (was reading from the provider). - `ReactPackageTurboModuleManagerDelegate.shouldEnableLegacyModuleInterop` — drop the flag from the AND with `useTurboModuleInterop`. No public API surfaces change. `arc f` auto-removed the now-unused `ReactNativeNewArchitectureFeatureFlags` imports in the affected files. Subsequent diffs in the stack will handle: `ReactDelegate` + deprecated constructors + `reactNativeHost` field; wrapper method + lint detector. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D106719839
meta-cla
Bot
added
the
CLA Signed
|
@mdvacca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106719839. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Second in a stack that collapses Android-side branches on
ReactNativeNewArchitectureFeatureFlags.enableBridgelessArchitecture()under the standing assumption that on Android the flag is alwaystrue. The underlying generatedReactNativeFeatureFlags.enableBridgelessArchitecture()is untouched.Scope of this commit — ReactAndroid simple call sites:
DevSupportManagerBase— drop the flag from the AND chain that gatesPerfMonitorOverlayManagercreation.HeadlessJsTaskService.reactContextgetter andcreateReactContextAndScheduleTask— keep thereactHostbranches; drop thereactInstanceManagerfallbacks.ViewManager.getNativeProps— drop the flag from the AND withUNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE.ReactImageView— delete thewarnImageSourcehelper and its two call sites. The helper existed only to emit a debug warning that was already gated off in bridgeless mode.ReactEditText.onConfigurationChanged— drop the flag from the AND withenableFontScaleChangesUpdatingLayout.ReactHostImpl.getOrCreateStartTask— drop the always-true debug assertion.DefaultNewArchitectureEntryPoint.loadWithFeatureFlags— setprivateBridgelessEnabled = truedirectly (was reading from the provider).ReactPackageTurboModuleManagerDelegate.shouldEnableLegacyModuleInterop— drop the flag from the AND withuseTurboModuleInterop.No public API surfaces change.
arc fauto-removed the now-unusedReactNativeNewArchitectureFeatureFlagsimports in the affected files.Subsequent diffs in the stack will handle:
ReactDelegate+ deprecated constructors +reactNativeHostfield; wrapper method + lint detector.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D106719839