Skip to content

Promote event loop control JSI interface (#57005) #57005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lavenzg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Promote event loop control JSI interface (#57005) #57005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/react-native/ReactCommon/jsi/jsi/hermes-interfaces.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ namespace debugger {
class Debugger;
}

#ifdef JSI_UNSTABLE
/// IEventLoopControl is defined by the integrator to allow the Runtime to
/// schedule some task to be run when convenient, and to keep track of "Task
/// sources". After it is set to a Runtime, the integrator must ensure that the
Expand Down Expand Up @@ -79,7 +78,6 @@ struct JSI_EXPORT ISetEventLoopControl : public jsi::ICast {
protected:
~ISetEventLoopControl() = default;
};
#endif

/// Interface for Hermes-specific runtime methods.The actual implementations of
/// the pure virtual methods are provided by Hermes API.
Expand Down
14 changes: 14 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,20 @@ class facebook::hermes::IHermesSHUnit : public facebook::jsi::ICast {
public virtual SHUnitCreator getSHUnitCreator() const = 0;
}

struct facebook::hermes::IEventLoopControl {
protected ~IEventLoopControl() = default;
public virtual uint64_t registerTaskQueueSource() = 0;
public virtual void scheduleTask(const std::function<void()>& task) = 0;
public virtual void unregisterTaskQueueSource(uint64_t sourceId) = 0;
}

struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast {
protected ~ISetEventLoopControl() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual facebook::hermes::IEventLoopControl* getEventLoopControl() = 0;
public virtual void setEventLoopControl(facebook::hermes::IEventLoopControl* eventLoopControl) = 0;
}


const char facebook::react::AndroidHorizontalScrollContentViewShadowNodeComponentName[];
const char facebook::react::AndroidProgressBarComponentName[];
Expand Down
14 changes: 14 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,20 @@ class facebook::hermes::IHermesSHUnit : public facebook::jsi::ICast {
public virtual SHUnitCreator getSHUnitCreator() const = 0;
}

struct facebook::hermes::IEventLoopControl {
protected ~IEventLoopControl() = default;
public virtual uint64_t registerTaskQueueSource() = 0;
public virtual void scheduleTask(const std::function<void()>& task) = 0;
public virtual void unregisterTaskQueueSource(uint64_t sourceId) = 0;
}

struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast {
protected ~ISetEventLoopControl() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual facebook::hermes::IEventLoopControl* getEventLoopControl() = 0;
public virtual void setEventLoopControl(facebook::hermes::IEventLoopControl* eventLoopControl) = 0;
}


const char facebook::react::AndroidHorizontalScrollContentViewShadowNodeComponentName[];
const char facebook::react::AndroidProgressBarComponentName[];
Expand Down
14 changes: 14 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,20 @@ class facebook::hermes::IHermesSHUnit : public facebook::jsi::ICast {
public virtual SHUnitCreator getSHUnitCreator() const = 0;
}

struct facebook::hermes::IEventLoopControl {
protected ~IEventLoopControl() = default;
public virtual uint64_t registerTaskQueueSource() = 0;
public virtual void scheduleTask(const std::function<void()>& task) = 0;
public virtual void unregisterTaskQueueSource(uint64_t sourceId) = 0;
}

struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast {
protected ~ISetEventLoopControl() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual facebook::hermes::IEventLoopControl* getEventLoopControl() = 0;
public virtual void setEventLoopControl(facebook::hermes::IEventLoopControl* eventLoopControl) = 0;
}


const char facebook::react::AndroidHorizontalScrollContentViewShadowNodeComponentName[];
const char facebook::react::AndroidProgressBarComponentName[];
Expand Down
14 changes: 14 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3750,6 +3750,20 @@ class facebook::hermes::IHermesSHUnit : public facebook::jsi::ICast {
public virtual SHUnitCreator getSHUnitCreator() const = 0;
}

struct facebook::hermes::IEventLoopControl {
protected ~IEventLoopControl() = default;
public virtual uint64_t registerTaskQueueSource() = 0;
public virtual void scheduleTask(const std::function<void()>& task) = 0;
public virtual void unregisterTaskQueueSource(uint64_t sourceId) = 0;
}

struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast {
protected ~ISetEventLoopControl() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual facebook::hermes::IEventLoopControl* getEventLoopControl() = 0;
public virtual void setEventLoopControl(facebook::hermes::IEventLoopControl* eventLoopControl) = 0;
}


const char facebook::react::AppleSwitchComponentName[];
const char facebook::react::ImageComponentName[];
Expand Down
14 changes: 14 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3376,6 +3376,20 @@ class facebook::hermes::IHermesSHUnit : public facebook::jsi::ICast {
public virtual SHUnitCreator getSHUnitCreator() const = 0;
}

struct facebook::hermes::IEventLoopControl {
protected ~IEventLoopControl() = default;
public virtual uint64_t registerTaskQueueSource() = 0;
public virtual void scheduleTask(const std::function<void()>& task) = 0;
public virtual void unregisterTaskQueueSource(uint64_t sourceId) = 0;
}

struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast {
protected ~ISetEventLoopControl() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual facebook::hermes::IEventLoopControl* getEventLoopControl() = 0;
public virtual void setEventLoopControl(facebook::hermes::IEventLoopControl* eventLoopControl) = 0;
}


const char facebook::react::AppleSwitchComponentName[];
const char facebook::react::ImageComponentName[];
Expand Down
14 changes: 14 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3750,6 +3750,20 @@ class facebook::hermes::IHermesSHUnit : public facebook::jsi::ICast {
public virtual SHUnitCreator getSHUnitCreator() const = 0;
}

struct facebook::hermes::IEventLoopControl {
protected ~IEventLoopControl() = default;
public virtual uint64_t registerTaskQueueSource() = 0;
public virtual void scheduleTask(const std::function<void()>& task) = 0;
public virtual void unregisterTaskQueueSource(uint64_t sourceId) = 0;
}

struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast {
protected ~ISetEventLoopControl() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual facebook::hermes::IEventLoopControl* getEventLoopControl() = 0;
public virtual void setEventLoopControl(facebook::hermes::IEventLoopControl* eventLoopControl) = 0;
}


const char facebook::react::AppleSwitchComponentName[];
const char facebook::react::ImageComponentName[];
Expand Down
14 changes: 14 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,20 @@ class facebook::hermes::IHermesSHUnit : public facebook::jsi::ICast {
public virtual SHUnitCreator getSHUnitCreator() const = 0;
}

struct facebook::hermes::IEventLoopControl {
protected ~IEventLoopControl() = default;
public virtual uint64_t registerTaskQueueSource() = 0;
public virtual void scheduleTask(const std::function<void()>& task) = 0;
public virtual void unregisterTaskQueueSource(uint64_t sourceId) = 0;
}

struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast {
protected ~ISetEventLoopControl() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual facebook::hermes::IEventLoopControl* getEventLoopControl() = 0;
public virtual void setEventLoopControl(facebook::hermes::IEventLoopControl* eventLoopControl) = 0;
}


const char facebook::react::AndroidProgressBarComponentName[];
const char facebook::react::AndroidSwitchComponentName[];
Expand Down
14 changes: 14 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,20 @@ class facebook::hermes::IHermesSHUnit : public facebook::jsi::ICast {
public virtual SHUnitCreator getSHUnitCreator() const = 0;
}

struct facebook::hermes::IEventLoopControl {
protected ~IEventLoopControl() = default;
public virtual uint64_t registerTaskQueueSource() = 0;
public virtual void scheduleTask(const std::function<void()>& task) = 0;
public virtual void unregisterTaskQueueSource(uint64_t sourceId) = 0;
}

struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast {
protected ~ISetEventLoopControl() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual facebook::hermes::IEventLoopControl* getEventLoopControl() = 0;
public virtual void setEventLoopControl(facebook::hermes::IEventLoopControl* eventLoopControl) = 0;
}


const char facebook::react::AndroidProgressBarComponentName[];
const char facebook::react::AndroidSwitchComponentName[];
Expand Down
14 changes: 14 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,20 @@ class facebook::hermes::IHermesSHUnit : public facebook::jsi::ICast {
public virtual SHUnitCreator getSHUnitCreator() const = 0;
}

struct facebook::hermes::IEventLoopControl {
protected ~IEventLoopControl() = default;
public virtual uint64_t registerTaskQueueSource() = 0;
public virtual void scheduleTask(const std::function<void()>& task) = 0;
public virtual void unregisterTaskQueueSource(uint64_t sourceId) = 0;
}

struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast {
protected ~ISetEventLoopControl() = default;
public static constexpr facebook::jsi::UUID uuid;
public virtual facebook::hermes::IEventLoopControl* getEventLoopControl() = 0;
public virtual void setEventLoopControl(facebook::hermes::IEventLoopControl* eventLoopControl) = 0;
}


const char facebook::react::AndroidProgressBarComponentName[];
const char facebook::react::AndroidSwitchComponentName[];
Expand Down
Loading