en-GB: Fix erroneous too strict rule for id_number (NI number) - #3319
Open
luke-hill wants to merge 1 commit into
Open
en-GB: Fix erroneous too strict rule for id_number (NI number)#3319luke-hill wants to merge 1 commit into
id_number (NI number)#3319luke-hill wants to merge 1 commit into
Conversation
I found this out by investigation that actually this would fail for a specific valid NI number (One that is known to be valid, but this system would detect it as invalid)
Contributor
Author
|
@stefanjcollier @stefannibrasil minor item to review. Should be an easy merge and fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this out by investigation that actually this would fail for a specific valid NI number (One that is known to be valid, but this system would detect it as invalid)
Original work / motivation from #3032
Motivation / Background
Fixed a bug whereby you cannot generate a valid NI number
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: