Repository navigation
Famedly release/v1.164 - #29
Open
jason-famedly wants to merge 13 commits into
Open
jason-famedly wants to merge 13 commits into
jason-famedly wants to merge 13 commits into
Conversation
MSC4140 schedules delayed events with
`PUT /rooms/{roomId}/delayed_event/{eventType}/{txnId}`, taking `delay_ms`,
`content` and, for state events, `state_key` in the body. Scheduling
through the `org.matrix.msc4140.delay` query parameter on `/send` and
`/state` is now one of the MSC's rejected alternatives.
Schedule every delayed event through the unstable form of the endpoint,
giving state events a transaction ID of their own. The existing
"same txnID" subtest now checks that the endpoint is transactional, and
the state event tests check that a state event scheduled through it
lands as room state. A new test checks that a missing, zero or negative
`delay_ms` is rejected with a 400.
One test still schedules a message event and a state event through the
query parameter, so that form stays covered until homeservers drop it.
Signed-off-by: Paul Chobert <paul@chobert.fr>
MSC4140 lists scheduling delayed events through the `org.matrix.msc4140.delay` query parameter on `/send` and `/state` as a rejected alternative to the dedicated endpoint, so it is not part of the MSC to test for. Remove the test that still used it, along with the `getPathForSend` and `getDelayQueryParam` helpers only it needed. Signed-off-by: Paul Chobert <paul@chobert.fr>
Signed-off-by: Shane Jaroch <chown_tee@proton.me>
…x-org#924) Signed-off-by: Paul Chobert <paul@chobert.fr>
Bumps the minor-and-patches group with 1 update in the / directory: [zizmorcore/zizmor-action](https://github.com/zizmorcore/zizmor-action). Updates `zizmorcore/zizmor-action` from 0.6.3 to 0.6.4 - [Release notes](https://github.com/zizmorcore/zizmor-action/releases) - [Commits](zizmorcore/zizmor-action@70fb788...cc914d7) --- updated-dependencies: - dependency-name: zizmorcore/zizmor-action dependency-version: 0.6.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patches ... Signed-off-by: dependabot[bot] <support@github.com>
…ctions/minor-and-patches-466e73e5ba Bump zizmorcore/zizmor-action from 0.6.3 to 0.6.4 in the minor-and-patches group across 1 directory
Co-authored-by: Quentin Gliech <quenting@element.io>
* Add minimal /send_join MSC4242 Complement tests This is to serve as regression tests for: - rejoining a room not working because we skipped seen events during processing - rejected events (due to cascading) being accepted because we didn't persist rejection status in-memory alongside the state group * Add TestMSC4242RejectionCascadesOnRejoin * Add TestMSC4242RejoinMergesOldAndNewStateDAGBranches * Review comments
…-endpoint MSC4140: schedule delayed events through the dedicated endpoint
FrenchGithubUser
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.