fix: extract trace context from diagnostics - #235
Open
YCCDSZXH wants to merge 2 commits into
Open
Conversation
Contributor
|
@YCCDSZXH Thanks for your contribution! I wonder if this patch would cause a:
... setup falls into an infinite loop, or duplicate log entries. cc @andylokandy |
tisonkun
approved these changes
Aug 6, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenTelemetry appender to extract trace context fields from diagnostics and attach them to emitted OpenTelemetry log records, enabling backend trace-log correlation.
Changes:
- Adds a
TraceContextExtractorvisitor wrapper to parsetrace_id,span_id, and sampling info from diagnostic key-values. - Sets
SdkLogRecordtrace context viaset_trace_context(...)when trace fields are present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Some(( | ||
| self.trace_id?, | ||
| self.span_id?, | ||
| TraceFlags::NOT_SAMPLED.with_sampled(self.sampled?), |
| .and_then(|value| SpanId::from_hex(value).ok()) | ||
| .filter(|span_id| *span_id != SpanId::INVALID); | ||
| } | ||
| "sampled" if self.sampled.is_none() => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.