Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that
anyOfandoneOfvalidate nested objects before calling theirtoJSON()methods. Properties supplied only bytoJSON()therefore cannot satisfy the branch's required properties.Add a README example showing explicit conversion, plus tests covering both keywords and the direct-object-schema comparison. This documents existing behavior; serialization semantics are unchanged.
Refs #621.
Verified locally on Linux with Node 26.7.0:
toJSONtests passed.AI assistance: OpenAI Codex helped research the issue, prepare the documentation and tests, and run the listed checks.