Repository navigation
fix: add string flattening to the benchmarks - #894
Open
ivan-tymoshenko wants to merge 1 commit into
Open
ivan-tymoshenko wants to merge 1 commit into
ivan-tymoshenko wants to merge 1 commit into
Conversation
Open
13 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark needs to consume the resulting string
One important detail is that returning a string does not necessarily mean all the work of building it has happened.
FJS returns an unflattened string (a tree of references to smaller string pieces, also called a rope). Native JSON.stringify returns a flat string, with its characters already stored contiguously. Concatenation can therefore look very cheap in a serialization-only benchmark because some copying is deferred.
I updated the benchmark to measure:
This includes serialization and byte length counting, without route or socket overhead. It does not include actual UTF-8 output encoding or the complete HTTP response path.
!! Please take a look at the last 3 bench cases that shows the real world responses.
*all the benchmarks includes unmerged optimization: #886
Results for nodejs 24.
Results for nodejs 26