This repository was archived by the owner on Aug 13, 2026. It is now read-only.
Repository navigation
Sort imports to satisfy ruff check - #7
Merged
Merged
Conversation
The Test workflow's lint step runs `uvx ruff check .`, which resolves the latest ruff at run time. Current ruff flags I001 on main.py's import block, so the step fails on every pull request. Apply `ruff check --fix`. No behaviour change; `ruff format --check` and `fastly compute build` both still pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
The
Testworkflow's lint step runsuvx ruff check ., which resolves the latestruffat run time. CurrentruffflagsI001(un-sorted import block) onmain.py, so the step fails on every pull request:This applies
ruff check --fix, which movesfrom flask import Flaskbelowfrom fastly_compute.wsgi import ...and separates the stdlib and third-party groups. No behaviour change.Verified locally:
uvx ruff check .→All checks passed!uvx ruff format --check .→3 files already formattedfastly compute build(CLI v15.5.0) →SUCCESS: Built packageFound while working on #6 / CDTOOL-1707, where this pre-existing failure turned that PR's CI red. Unrelated to the change there, so it's split out here. Merging this first and rebasing #6 should get both green.
FWIW the
Testworkflow has never passed on this repo: earlier runs got past lint but failed atBuild (using CLI), which looks like it was the released CLI not yet supportinglanguage = "python". That shipped in CLI v15.5.0, and the build now succeeds locally, so this lint fix should be the last thing standing between the workflow and a green run.🤖 Generated with Claude Code