Repository navigation
fix(server): nil passive port range crashes passive transfers - #1845
Merged
Merged
Conversation
Without `passive_transfer_port_range` in the config, every passive transfer failed (WinSCP: "value method PortRange.NumberAttempts called using nil *PortRange pointer"). server/server.go:83 stored a nil *PortRange in the PasvPortGetter interface, which made it non-nil, so ftpserverlib took the port-range path. The port range is now declared as the interface. TestSettingsWithoutPassivePortRange failed before the fix. Closes #1825 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fclairamb
added
the
frozen
# Conflicts: # server/server.go # server/server_internal_test.go
fclairamb
marked this pull request as ready for review
October 30, 2026 05:58
fclairamb
added a commit
that referenced
this pull request
Oct 30, 2026
🤖 I have created a release *beep* *boop* --- ## [0.16.5](v0.16.4...v0.16.5) (2026-10-30) ### Bug Fixes * always check keycloak credentials, even on shared accesses ([#1848](#1848)) ([9a24e42](9a24e42)) * **deps:** update github.com/fclairamb/ftpserverlib to v0.32.6 ([#1850](#1850)) ([ec4f71b](ec4f71b)) * **server:** nil passive port range crashes passive transfers ([#1845](#1845)) ([b7dbc33](b7dbc33)) * **server:** random default password, mail upload limit, non-root images, token file mode, pinned release action ([#1847](#1847)) ([60645ff](60645ff)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Florent Clairambault <florent.clairambault@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nil
*PortRangestored in the settings interface whenpassive_transfer_port_rangeis not configured: ftpserverlib took the port-range path and panicked on every passive transfer (WinSCP error in the issue).Closes #1825
🤖 Generated with Claude Code