Skip to content

Fix flaky test in login.test.ts (normalizes CLI login origins and preserves the allowlist) #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dodok8 merged 2 commits into from
Oct 6, 2026
Merged

Fix flaky test in login.test.ts (normalizes CLI login origins and preserves the allowlist) #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a6018c
Remove serverTimeout in test
dodok8 Oct 6, 2026
ea69a07
Set 2 min timeout to login.test.ts spawn process
dodok8 Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/drfed/src/login.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import process from "node:process";
import { it } from "node:test";
import { fileURLToPath } from "node:url";

const serverTimeout = 30_000;
const requestTimeout = 5_000;
const binary = fileURLToPath(
new URL("../bin/drfed-server.mjs", import.meta.url),
Expand Down Expand Up @@ -55,9 +54,9 @@ it("normalizes CLI login origins and preserves the allowlist", async () => {
"--login-origin=http://[::1]:3000",
],
{
env: { PATH: process.env.PATH ?? "" },
timeout: serverTimeout,
timeout: 120_000,
killSignal: "SIGKILL",
env: { PATH: process.env.PATH ?? "" },
stdio: ["ignore", "pipe", "pipe"],
},
);
Expand All @@ -75,7 +74,10 @@ it("normalizes CLI login origins and preserves the allowlist", async () => {
child.once("error", ready.reject);
child.once("close", (code, signal) => {
ready.reject(
new Error(`CLI exited before listening (${code}, ${signal}): ${stderr}`),
new Error(
`CLI exited before listening (${code}, ${signal})\n` +
`stdout:\n${stdout}\nstderr:\n${stderr}`,
),
);
closed.resolve();
});
Expand Down
Loading