Repository navigation
DE-MV, DE-TH, EC-LT, EC-LV, EC-SI: complete and valid output - #349
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…irst 20,000 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… rejects Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the dataset-converter fixes.
No open issues 🎉
What changed in this PR
This PR fixes incomplete or invalid output from five dataset converters, improving field coverage and compliance with fiboa schemas.
Changes:
- Pages DE-MV’s WFS requests to retrieve all field blocks.
- Treats missing prior-year area in DE-TH as empty and completes required crop fields for EC-LT, EC-LV, and EC-SI.
- Adds regression checks for WFS pagination and crop-column presence.
| File | Description |
|---|---|
tests/test_converter_wfs.py |
Checks DE-MV pagination, sorting, and count-request parameters. |
tests/test_convert.py |
Requires crop code and code-list columns for the three EuroCrops converters. |
fiboa_cli/datasets/ec_si.py |
Adds crop codes and code-list metadata; excludes parcels without crops. |
fiboa_cli/datasets/ec_lv.py |
Adds crop code-list metadata. |
fiboa_cli/datasets/ec_lt.py |
Uses the crop group name as the crop code. |
fiboa_cli/datasets/de_th.py |
Converts nonpositive prior-year area to empty and makes the field optional. |
fiboa_cli/datasets/de_mv.py |
Uses sorted WFS pagination and omits output format from count requests. |
CHANGELOG.md |
Documents the converter fixes. |
Review effort: Balanced
m-mohr
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the converters whose output failed
fiboa validateor was incomplete, found when the catalog's single-edition collections were rebuilt.WFSConverterMixin, sorted byfbidso the pages do not overlap. The count request leaves out the output format, which the service rejects with a 500.area_last_yearfor a field block that is new this year; that is now empty, and the field no longer required.crop:code,crop:code_listor both. Lithuania's code list is keyed on the group name, so the name is also the code; Slovenia's code isSIFRA_KMRS; EC-SI leaves out the parcels without a crop.expected_columnsnow guards these fields.🤖 Generated with Claude Code