Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FirebaseAdmin/FirebaseAdmin/AppOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ internal AppOptions(AppOptions options)
public string ServiceAccountId { get; set; }

/// <summary>
/// Gets or sets the HttpClientFactory to use when making Firebase requests.
/// Gets or sets the IHttpClientFactory to use when making Firebase requests.
/// </summary>
public HttpClientFactory HttpClientFactory { get; set; }
public IHttpClientFactory HttpClientFactory { get; set; }
Comment thread
Wolffy101 marked this conversation as resolved.
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public override Task<string> GetKeyIdAsync(

internal class Args
{
internal HttpClientFactory ClientFactory { get; set; }
internal IHttpClientFactory ClientFactory { get; set; }

internal GoogleCredential Credential { get; set; }

Expand Down
4 changes: 2 additions & 2 deletions FirebaseAdmin/FirebaseAdmin/Auth/Jwt/HttpPublicKeySource.cs
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ internal sealed class HttpPublicKeySource : IPublicKeySource
private readonly SemaphoreSlim cacheLock = new SemaphoreSlim(1, 1);
private readonly string certUrl;
private readonly IClock clock;
private readonly HttpClientFactory clientFactory;
private readonly IHttpClientFactory clientFactory;
private DateTime expirationTime;
private IReadOnlyList<PublicKey> cachedKeys;

public HttpPublicKeySource(string certUrl, IClock clock, HttpClientFactory clientFactory)
public HttpPublicKeySource(string certUrl, IClock clock, IHttpClientFactory clientFactory)
{
this.certUrl = certUrl.ThrowIfNullOrEmpty(nameof(certUrl));
this.clock = clock.ThrowIfNull(nameof(clock));
Expand Down
4 changes: 2 additions & 2 deletions FirebaseAdmin/FirebaseAdmin/Auth/Jwt/IAMSigner.cs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ internal class IAMSigner : ISigner
private readonly Lazy<Task<string>> keyId;

public IAMSigner(
HttpClientFactory clientFactory, GoogleCredential credential, RetryOptions retryOptions = null)
IHttpClientFactory clientFactory, GoogleCredential credential, RetryOptions retryOptions = null)
{
this.httpClient = new ErrorHandlingHttpClient<FirebaseAuthException>(
new ErrorHandlingHttpClientArgs<FirebaseAuthException>()
Expand Down Expand Up @@ -114,7 +114,7 @@ internal static IAMSigner Create(FirebaseApp app)
}

private static async Task<string> DiscoverServiceAccountIdAsync(
HttpClientFactory clientFactory)
IHttpClientFactory clientFactory)
{
using (var client = clientFactory.CreateDefaultHttpClient())
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ internal sealed class Args
{
internal FirebaseApp App { get; set; }

internal HttpClientFactory ClientFactory { get; set; }
internal IHttpClientFactory ClientFactory { get; set; }

internal GoogleCredential Credential { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ internal PagedAsyncEnumerable<AuthProviderConfigs<SamlProviderConfig>, SamlProvi

internal sealed class Args
{
internal HttpClientFactory ClientFactory { get; set; }
internal IHttpClientFactory ClientFactory { get; set; }

internal GoogleCredential Credential { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ private async Task<DeserializedResponseInfo<TResult>> PostAndDeserializeAsync<TR

internal sealed class Args
{
internal HttpClientFactory ClientFactory { get; set; }
internal IHttpClientFactory ClientFactory { get; set; }

internal GoogleCredential Credential { get; set; }

Expand Down
4 changes: 2 additions & 2 deletions FirebaseAdmin/FirebaseAdmin/Extensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ public static ServiceAccountCredential ToServiceAccountCredential(
/// factory.
/// </summary>
/// <returns>An HTTP client that can be used to make unauthenticated requests.</returns>
/// <param name="clientFactory">The <see cref="HttpClientFactory"/> used to create
/// <param name="clientFactory">The <see cref="IHttpClientFactory"/> used to create
/// the HTTP client.</param>
public static ConfigurableHttpClient CreateDefaultHttpClient(
this HttpClientFactory clientFactory)
this IHttpClientFactory clientFactory)
{
return clientFactory.CreateHttpClient(new CreateHttpClientArgs());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ internal class SingleMessageResponse

internal sealed class Args
{
internal HttpClientFactory ClientFactory { get; set; }
internal IHttpClientFactory ClientFactory { get; set; }

internal GoogleCredential Credential { get; set; }

Expand Down
2 changes: 1 addition & 1 deletion FirebaseAdmin/FirebaseAdmin/Messaging/InstanceIdClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ internal sealed class InstanceIdClient : IDisposable
/// <param name="credential">An instance of the <see cref="GoogleCredential"/> class.</param>
/// <param name="retryOptions">An instance of the <see cref="RetryOptions"/> class.</param>
internal InstanceIdClient(
HttpClientFactory clientFactory, GoogleCredential credential, RetryOptions retryOptions = null)
IHttpClientFactory clientFactory, GoogleCredential credential, RetryOptions retryOptions = null)
{
this.httpClient = new ErrorHandlingHttpClient<FirebaseMessagingException>(
new ErrorHandlingHttpClientArgs<FirebaseMessagingException>()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ namespace FirebaseAdmin.Util
internal sealed class ErrorHandlingHttpClientArgs<T>
where T : FirebaseException
{
internal HttpClientFactory HttpClientFactory { get; set; }
internal IHttpClientFactory HttpClientFactory { get; set; }

internal GoogleCredential Credential { get; set; }

Expand Down
Loading