Skip to content

test(firestore): use TARGET_DATABASE_ID in lifecycle integration tests - #8623

Merged
wu-hui merged 1 commit into
mainfrom
fix-nightly-lifecycle-tests
Sep 22, 2026
Merged

wu-hui merged 1 commit into
mainfrom
fix-nightly-lifecycle-tests

Conversation

@wu-hui

@wu-hui wu-hui commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Pass BuildConfig.TARGET_DATABASE_ID to FirebaseFirestore.getInstance(app, BuildConfig.TARGET_DATABASE_ID) in testRestartFirestoreLeadsToNewInstance() and testAppDeleteLeadsToFirestoreTerminate().

Context

When running Nightly integration tests against the regional us-central1-test-firestore.sandbox.googleapis.com endpoint (TARGET_DATABASE_ID="enterprise" in us-central1), calling FirebaseFirestore.getInstance(app) defaults to the (default) database (located in nam5), causing network writes in these two lifecycle tests to time out.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@google-oss-bot

Copy link
Copy Markdown
Collaborator

Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR or 'NO_RELEASE_CHANGE' to the description to silence this warning.)

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@wu-hui
wu-hui merged commit 55f9bd9 into main Sep 22, 2026
35 checks passed
@wu-hui
wu-hui deleted the fix-nightly-lifecycle-tests branch September 22, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants