[wahajahmed010]

Description

When HTTPS_PROXY (or HTTP_PROXY) is set, every request the CLI makes goes through new undici.ProxyAgent({ uri: proxyURI }). That agent does not honor NO_PROXY/no_proxy, so requests between emulators on 127.0.0.1 are also proxied. Behind a corporate or sandbox proxy, the Functions emulator then fails to register its Firestore trigger and emulators:start/emulators:exec errors out with ECONNREFUSED.

This PR swaps undici.ProxyAgent for undici.EnvHttpProxyAgent, which is built on top of ProxyAgent and applies the same NO_PROXY/no_proxy rules as Node.js and other CLIs. The proxy URI is passed as both httpProxy and httpsProxy; noProxy is read from the same environment variables that other Node tools consult.

Fixes #11249

Scenarios Tested

• With HTTPS_PROXY=http://127.0.0.1:52672 and NO_PROXY=127.0.0.1, a request to http://127.0.0.1:52673 succeeds and reaches the target server.
• Without NO_PROXY, requests are still proxied (existing behavior preserved).
• All existing tests in src/apiv2.spec.ts continue to pass (41/41 passing). One new test was added that asserts the NO_PROXY bypass branch.
• tsc --project tsconfig.compile.json is clean (0 errors).

Sample Commands

# Triggers the bug before the patch
export HTTPS_PROXY=http://127.0.0.1:9
export NO_PROXY=localhost,127.0.0.1
firebase emulators:exec --project demo-repro --only firestore,functions "echo hi"
# Before: ECONNREFUSED 127.0.0.1:9
# After:  Functions emulator registers the trigger and the script runs.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Code Review

This pull request replaces ProxyAgent with EnvHttpProxyAgent from undici in src/apiv2.ts to ensure that NO_PROXY/no_proxy environment variables are properly honored, and adds a corresponding unit test in src/apiv2.spec.ts. The reviewer suggests extracting a shared helper getEnvVar to handle environment variable retrieval and filter out literal 'undefined' or 'null' strings, which prevents potential issues when checking fallback variables. Additionally, the reviewer recommends using this helper to separately configure httpProxy and httpsProxy rather than forcing both to use the same proxy URI.

[gemini-code-assist]

If process.env.NO_PROXY is set to the literal string "undefined", the expression process.env.NO_PROXY || process.env.no_proxy will evaluate to "undefined", which prevents a potentially valid process.env.no_proxy from being used.\n\nAdditionally, to adhere to the repository style guide's rule on Survey prior art & harmonize utilities (lines 28-30), we should extract a shared helper to retrieve environment variables while filtering out "undefined" and "null" strings. This helper can then be reused by both proxyURIFromEnv and noProxyFromEnv.

function getEnvVar(keys: string[]): string | undefined {\n  for (const key of keys) {\n    const val = process.env[key];\n    if (val && val !== \"undefined\" && val !== \"null\") {\n      return val;\n    }\n  }\n  return undefined;\n}\n\nfunction noProxyFromEnv(): string {\n  return getEnvVar([\"NO_PROXY\", \"no_proxy\"]) || \"\";\n}

References

1. Survey prior art & harmonize utilities: Extract and unify shared helpers when logic is duplicated or warrants a new common utility. ^(link)

[gemini-code-assist]

Currently, both httpProxy and httpsProxy are set to the same proxyURI (which prefers HTTPS_PROXY over HTTP_PROXY). In environments where separate proxies are configured for HTTP and HTTPS, this forces HTTP requests to go through the HTTPS proxy.\n\nSince we are using EnvHttpProxyAgent, we can leverage the getEnvVar helper to pass the correct proxy for each protocol individually.

      fetchOptions.dispatcher = new EnvHttpProxyAgent({\n        httpProxy: getEnvVar([\"HTTP_PROXY\", \"http_proxy\"]),\n        httpsProxy: getEnvVar([\"HTTPS_PROXY\", \"https_proxy\"]),\n        noProxy: noProxyFromEnv(),\n      });