[joehan]

Description

Fixes #11308.

• Upgrades chokidar from ^3.6.0 to ^4.0.3 in package.json and updates npm-shrinkwrap.json.
• Resolves the High security advisory on braces (GHSA-vfj7-8cjw-p6xm), removing braces from the production dependency graph as chokidar@4 only depends on readdirp@^4.0.1.
• Adds an override for @angular-devkit/core's optional peer dependency on chokidar ("@angular-devkit/core": { "chokidar": "$chokidar" }).
• Adapts the Functions emulator file watcher (src/emulator/functionsEmulator.ts) to use minimatch for backend.ignore pattern matching, preserving glob ignore functionality under chokidar@4 (which dropped native glob matching in favor of matcher functions and regexes).
• Retains CommonJS and Node >= 14.16.0 compatibility (supporting Node 20.18 standalone binaries).
• Adds unit tests in src/emulator/functionsEmulatorUtils.spec.ts for the Functions emulator ignore filter.

Scenarios Tested

• npm audit --omit=dev --json verified that braces is completely removed from the production dependency graph.
• Node 20.18.3 compatibility verified by executing CJS require() against all built emulator modules (databaseEmulator.js, firestoreEmulator.js, functionsEmulator.js, storage/rules/manager.js).
• npm run build passed (TypeScript and Vite compilation).
• npm run lint:quiet passed (ESLint and Prettier across all files).
• Unit test suites passed:
  • src/emulator/functionsEmulatorUtils.spec.ts (30 passing)
  • src/emulator/databaseEmulator.spec.ts (4 passing)
  • src/emulator/storage/rules/config.spec.ts and src/emulator/storage/rules/runtime.spec.ts (13 passing)
• Lockfile cleanliness verified with npm run sanitize:lockfile and reproducible lockfile generation.

Sample Commands

N/A

[gemini-code-assist]

Code Review

This pull request introduces a helper function createIgnoredFilter to centralize and standardize the logic for ignoring files in the functions emulator, improving maintainability and testability. The changes include updating the chokidar dependency to version 4.0.3, adding the necessary minimatch dependency, and refactoring the file watcher configuration. Unit tests have been added to verify the ignore logic. I have included a review comment suggesting the pre-compilation of minimatch patterns to enhance performance during file-watching operations.

[gemini-code-assist]

Pre-compiling the minimatch patterns into Minimatch instances outside of the file-matching callback avoids recompiling the glob patterns or performing repetitive cache lookups for every single file and directory during the file-watching process. This significantly improves the efficiency of the file watcher, especially in larger projects with many files.

    const minimatchInstances = ignore.map((pattern) => {
      const p = pattern.startsWith("**/") ? pattern : `**/${pattern}`;
      return new minimatch.Minimatch(p, { dot: true });
    });
    ignored.push((filePath: string) => {
      const normalized = filePath.replace(/\\/g, "/");
      return minimatchInstances.some((m) => m.match(normalized));
    });

[joehan]

Good call.

[joehan]

Fixed in commit dba5f87 by pre-compiling the ignore patterns into minimatch.Minimatch instances outside the matcher callback.