chore: modernize jest and dependencies, fix path parameter security bug#67
Open
inlined wants to merge 6 commits into
Open
chore: modernize jest and dependencies, fix path parameter security bug#67inlined wants to merge 6 commits into
inlined wants to merge 6 commits into
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
There was a problem hiding this comment.
Code Review
This pull request upgrades the Node.js runtime to version 18, updates several dependencies, and introduces security enhancements to the path parameterization logic to prevent path injection and empty path parameters. A review comment points out that the check if (!val) in parameterizePath will incorrectly reject valid falsy values like 0 or false. It is recommended to explicitly check for undefined, null, or "" instead, as well as fix a misleading type annotation and a typo in the log messages.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Audit & Remediation: firestore-bundle-builder
A. Previous CVEs
underscoreGHSA-qpx9-hpmf-5gmw,uuidGHSA-w5hq-g745-h8pq,wsGHSA-3h5v-q93c-6h6q,yargs-parserGHSA-p9pc-299p-vxgp,websocket-driverGHSA-mp7j-qc5w-4988,word-wrapGHSA-j8xg-fqg3-53r7).B. Changes Made
.map()path parameterization logic inparameterizePathto validate path segments, ensuring they don't contain any slashes (/), and throwHttpsError('invalid-argument', "Invalid argument provided for $part).@types/jest,jest,ts-jest,typescript,ts-node,tslint) todevDependencies.firebase-functionsto7.3.0firebase-adminto^12.7.0,@google-cloud/firestoreto^7.7.0, and@google-cloud/storageto^7.7.0.extension.yamlfromnodejs14tonodejs18and updatedengines.nodeinpackage.jsonto>=22.C. Remaining CVEs
D. Introduced CVEs
E. Testing Strategy
bundle.test.ts(100% passing).Release Notes
relnote: chore: modernize dependencies and fix path traversal vulnerability in path parameterizer