Skip to content

fix(auth,windows): complete reauthenticateWithCredential on success - #18653

Open
SelaseKay wants to merge 4 commits into
mainfrom
fix/auth-windows-reauthenticate-with-credential
Open

fix(auth,windows): complete reauthenticateWithCredential on success#18653
SelaseKay wants to merge 4 commits into
mainfrom
fix/auth-windows-reauthenticate-with-credential

Conversation

@SelaseKay

@SelaseKay SelaseKay commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

On Windows, User.reauthenticateWithCredential() never completed when the credential was valid. The C++ plugin called User::Reauthenticate(), which returns Future<void>, then left the Pigeon success branch empty (// TODO: wrong return type). Dart's Future stayed pending forever. Invalid credentials still failed normally because only the error branch invoked result.

This switches to User::ReauthenticateAndRetrieveData(), which returns AuthResult, and completes the Pigeon callback the same way as LinkWithCredential / ReauthenticateWithProvider.

The reauthenticateWithCredential() e2e group now runs on Windows. The last case in that group is skipped on Windows and macOS because it exercises signInWithEmailAndPassword, not reauthentication (a test-level skip overrides the group skip). The user-mismatch assertion accepts the Windows C++ SDK message, which omits the trailing period. macOS still skips the rest of the group.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Call ReauthenticateAndRetrieveData so the Pigeon callback receives an AuthResult on success instead of leaving the Dart Future pending.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Lift the success case out of the desktop-skipped group so Windows CI covers the previously hanging path without enabling error-message assertions.
Enable the group on Windows and skip only the sign-in case that does not exercise reauthenticateWithCredential. macOS remains skipped.
Accept the Windows C++ SDK user-mismatch message without a trailing period, and skip the unrelated sign-in case on macOS as well so its test-level skip does not override the group skip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

馃悰 [firebase_auth] Windows: reauthenticateWithCredential never completes on success

1 participant