fix(auth,windows): complete reauthenticateWithCredential on success - #18653
fix(auth,windows): complete reauthenticateWithCredential on success#18653SelaseKay wants to merge 4 commits into
Conversation
Call ReauthenticateAndRetrieveData so the Pigeon callback receives an AuthResult on success instead of leaving the Dart Future pending.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Lift the success case out of the desktop-skipped group so Windows CI covers the previously hanging path without enabling error-message assertions.
Enable the group on Windows and skip only the sign-in case that does not exercise reauthenticateWithCredential. macOS remains skipped.
Accept the Windows C++ SDK user-mismatch message without a trailing period, and skip the unrelated sign-in case on macOS as well so its test-level skip does not override the group skip.
Description
On Windows,
User.reauthenticateWithCredential()never completed when the credential was valid. The C++ plugin calledUser::Reauthenticate(), which returnsFuture<void>, then left the Pigeon success branch empty (// TODO: wrong return type). Dart'sFuturestayed pending forever. Invalid credentials still failed normally because only the error branch invokedresult.This switches to
User::ReauthenticateAndRetrieveData(), which returnsAuthResult, and completes the Pigeon callback the same way asLinkWithCredential/ReauthenticateWithProvider.The
reauthenticateWithCredential()e2e group now runs on Windows. The last case in that group is skipped on Windows and macOS because it exercisessignInWithEmailAndPassword, not reauthentication (a test-level skip overrides the group skip). Theuser-mismatchassertion accepts the Windows C++ SDK message, which omits the trailing period. macOS still skips the rest of the group.Related Issues
Checklist
///).melos run analyze) does not report any problems on my PR.Breaking Change