Repository navigation
fix: count retrieval misses in engine rank denominators - #1
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
score_pass()divides repo/fix engine rank-1 and MRR totals by hits rather than all attempted items. Ranks [1, 2, miss, timeout] therefore report MRR 0.75 rather than 0.375. Use the full denominator consistently with the documented rule and docs track; preserve undefined values for native arms without ranked observations.Nine synthetic regressions cover arithmetic, misses, timeout, depth cap, all-miss and native cases. Against exact upstream production: 6 fail, 3 pass. Fixed full Python 3.11 suite: 141 passed. Base-to-head diff check passes. No paid API calls or published result tables changed; historical engine diagnostic metrics need rescoring.
AI-assisted contribution; code and regression evidence reviewed before submission.