Repository navigation
fix: reject lookalike canonical documentation URLs - #2
Open
rudycelekli wants to merge 2 commits into
Open
rudycelekli wants to merge 2 commits into
rudycelekli wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canonical docs matcher uses a raw prefix check, so
docs.example.com.evil.test/guidescores asdocs.example.com/guide, and/docs-other/guideas/docs/guide. Require a host/base-path boundary while preserving existing URL normalization and page-stem rules.Adds 16 offline cases, including report-generation coverage where a canonical URL plus a lookalike incorrectly scores 1.0 instead of 0.5. Seven cases fail on exact upstream; all 148 tests pass on Python 3.11 with the patch. Base-to-head diff check passes.
This corrects scoring behavior. Published tables remain untouched; maintainers should rescore saved records before updating affected numbers. No provider calls were made.
AI-assisted contribution; code and regression evidence reviewed before submission.