Repository navigation
fix: reject docs scores without scoring ground truth - #4
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs reports can silently score every item as a retrieval miss when scoring metadata is missing or empty. The existing coverage guard bypasses an empty map, and the public reporter and direct pass scorer never invoke it.
Apply the same coverage guard to all docs scoring entrypoints and remove its empty-map bypass. Missing qids now fail with the existing dataset diagnostic; an actual retrieval miss with available ground truth still scores zero. No matching rules or published score definitions change.
Validation: 5 new regressions fail against upstream production code; all 139 tests pass after the fix on Python 3.11. The cases exercise the real public report, published report and direct pass scorer with synthetic records and no API calls. CI adds the already-declared numpy dependency for the public-reporter regression.
git diff --checkpasses.