Skip to content

fix: isolate fresh run directories and exact resume labels - #6

Open
rudycelekli wants to merge 1 commit into
firecrawl:mainfrom
rudycelekli:fix/run-directory-isolation
Open

rudycelekli wants to merge 1 commit into
firecrawl:mainfrom
rudycelekli:fix/run-directory-isolation

Conversation

@rudycelekli

Copy link
Copy Markdown

A fresh run_cell invocation can reuse an earlier directory when both start in the same second, inheriting or overwriting saved cells despite the fresh-run contract. Automatic resume also interprets labels as suffix globs: example can resume team-example, and a literal * can select another experiment.

Reserve fresh directories exclusively, add a sortable padded timestamp suffix on collisions, and match the complete automatic-resume label literally. Reject labels containing path separators, NUL, or dot path components before starting a subprocess. Existing explicit resume paths remain supported.

Validation: all 11 new synthetic regressions fail against the base; the full suite passes with 143 tests on Python 3.11. Tests cover saved-byte preservation, same-second freshness, newest resume after collision, suffix-label isolation, literal glob characters and invalid paths. git diff --check passes. No provider calls, score definitions or published results changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant