Repository navigation
fix: reject duplicate or mismatched repeated-pass cohorts - #7
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reporters currently average different or incomplete repeated query sets as though every pass measured the same items. Duplicate qids can also give an item extra weight. The published aggregator retains the first pass's item count, so these malformed repetitions can produce plausible but misleading scores.
Validate nonempty query identities, reject duplicate qids within each pass, and require equal query sets across repeated passes before scoring. Both report entrypoints use the same guard. Reordering, a single smoke subset and normal repeated measurements remain valid; per-item scoring and bootstrap formulas are unchanged.
Validation: 10 new regressions fail against the base; all 145 tests pass on Python 3.11. Tests exercise real public and published reports with partial/empty/different cohorts, duplicate or missing identities, reordered valid repetitions and a valid smoke subset. CI installs the already-declared numpy dependency for public-reporter imports.
git diff --checkpasses; no provider calls.Compatibility: the canonical-URL PR's synthetic two-task fixture now uses distinct qids in its updated head, and all eight proposed fixes together pass 220 tests locally.