Skip to content

fix: derive GitHub provenance from the actual URL origin - #8

Open
rudycelekli wants to merge 1 commit into
firecrawl:mainfrom
rudycelekli:fix/github-provenance-origin
Open

rudycelekli wants to merge 1 commit into
firecrawl:mainfrom
rudycelekli:fix/github-provenance-origin

Conversation

@rudycelekli

Copy link
Copy Markdown

GitHub provenance extraction searches the entire URL string. An engine result such as https://notgithub.com/o/r/issues/12 or an external redirect containing a GitHub URL can therefore be credited as the actual gold artifact. This can falsely inflate grounded precision and pool_hit. Numeric artifact prefixes such as /issues/12wrong can also become issue 12.

Derive GitHub references from the actual HTTP(S) GitHub authority and path, preserving default ports, genuine issue/PR/repository forms and .git normalization. Native stream provenance now uses the same origin-aware extraction instead of searching arbitrary text for GitHub substrings.

Validation: 8 new regressions fail against the base; all 148 tests pass on Python 3.11. Tests include a real Controller-to-scorer false-grounding example and execute the actual native stream-result loop without importing its SDK setup. Lookalike hosts, userinfo lookalikes, mirror paths, redirect/fragment parameters, invalid ports and malformed artifact numbers are covered. git diff --check passes. No live provider calls, gold matching definitions or published score artifacts changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant