fix(crawl): keep wait polling in seconds#143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firecrawl crawl --waitSDK waiter options in seconds instead of milliseconds.--wait --progressmillisecond conversion local to its custom polling loop.firecrawl-clito1.19.19.Why
The bundled
firecrawlSDK multipliespollIntervalandtimeoutby 1000 internally when waiting for crawl completion. The CLI was already multiplying those values before callingapp.crawl, so--poll-interval 5became roughly 83 minutes between status checks in non-progress wait mode.Fixes firecrawl/firecrawl#3373
Test plan
pnpm exec vitest run src/__tests__/commands/crawl.test.tspnpm run buildpnpm testpnpm run format:check