Repository navigation
fix: plain output when the CLI is not attached to a terminal - #349
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 13 files
Confidence score: 4/5
- In
src/utils/terminal.ts, an emptyNO_COLORvalue still disables color. Check that the value is non-empty before disabling it. - In
src/__tests__/utils/spinner.test.ts, the assertion can pass with an incorrect frame count. Assert the exact sequence length.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/__tests__/utils/spinner.test.ts">
<violation number="1" location="src/__tests__/utils/spinner.test.ts:85">
P3: This assertion is looser than the deterministic behavior. Under fake timers the sequence is exactly three frames, then the clear, then the final line, so assert the exact length to catch regressions in frame count.</violation>
</file>
<file name="src/utils/terminal.ts">
<violation number="1" location="src/utils/terminal.ts:10">
P3: `NO_COLOR` should only disable color when it is non-empty, per the no-color.org convention this change follows. Check `process.env.NO_COLOR` truthiness (non-empty) instead of `!== undefined`.</violation>
</file>
Shadow auto-approve: would not auto-approve because issues were found.
Click Fix with cubic on a comment, or reply @cubic-dev-ai fix this, and cubic writes the fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Fixes CLI progress output when stderr is not a terminal by printing plain lines only when the message changes, and centralizes TTY-aware color handling; a focused, tested bug fix with no rollout, policy, or contract change.
View guided diff | Turn on auto-fix | Re-trigger cubic
rakshith48
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firecrawl agent --waitwith stderr piped, 2s:Behavior change: with both
NO_COLORandFORCE_COLORset,doctornow followsNO_COLOR, the same as the update notices.