Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6276 +/- ##
==========================================
+ Coverage 83.84% 83.93% +0.09%
==========================================
Files 352 353 +1
Lines 37807 38031 +224
Branches 10674 10634 -40
==========================================
+ Hits 31698 31921 +223
- Misses 5679 5681 +2
+ Partials 430 429 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
canova
requested changes
Sep 8, 2026
canova
left a comment
canova
left a comment
Member
There was a problem hiding this comment.
Looks like a good idea. Some nits.
Nit: let's add this command to profiler-cli/README.md too.
thread markers searches one thread, so finding which of 95 threads saw a marker meant a shell loop of one invocation per thread. profile markers searches every thread in one call and reports matches with a thread column, following the shape of profile logs. The command requires at least one filter: unfiltered it would print an arbitrary slice of 2.4M markers, which answers no question. An explicit --limit opts into browsing anyway. Like thread markers --list, a filtered query returns every match rather than a truncated default, so a search never silently hides hits. Rows are capped at 100000, the most the reply can carry; the per-thread counts stay exact.
fqueze
force-pushed
the
profiler-cli-profile-markers-pr
branch
from
September 14, 2026 16:16
a2a6430 to
cb1f221
Compare
canova
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
thread markers searches one thread, so finding which of 95 threads saw a marker meant a shell loop of one invocation per thread. profile markers searches every thread in one call and reports matches with a thread column, following the shape of profile logs.
The command requires at least one filter: unfiltered it would print an arbitrary slice of 2.4M markers, which answers no question. An explicit --limit opts into browsing anyway.
Like thread markers --list, a filtered query returns every match rather than a truncated default, so a search never silently hides hits. Rows are capped at 100000, the most the reply can carry; the per-thread counts stay exact.