Wrap the attach row so Compose stays reachable in a narrow panel - #39
Open
DaveTseng2019 wants to merge 1 commit into
Open
Wrap the attach row so Compose stays reachable in a narrow panel#39DaveTseng2019 wants to merge 1 commit into
DaveTseng2019 wants to merge 1 commit into
Conversation
The toolbar got a WrapPanel in firish#25, but the attach card's header row was still a horizontal StackPanel. At a docked/narrow panel width the hint text plus Paste/Compose/Clear overflow the card: the panel grows a horizontal scrollbar and Compose sits half outside the visible area, so the button is there but unclickable without scrolling. Same fix as the toolbar - swap the StackPanel for a WrapPanel. Wide panels are unchanged (everything still fits on one line); narrow ones put the buttons on a second line. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #25, found while checking the 1.19.0 panel in the experimental hive.
The problem
#25 gave the toolbar a
WrapPanel, but the attach card's header row was still a horizontalStackPanel. At a docked/narrow panel width the hint text plusPaste/Compose/Clearoverflow the card: the panel grows a horizontal scrollbar andComposesits half outside the visible area. The button is technically there, but you have to scroll sideways to click it — which is not obvious, since nothing else in the panel scrolls horizontally.I hit it on a plain right-docked panel at 1.19.0, so it is not an exotic width.
The fix
One line: swap the
StackPanelfor aWrapPanel, the same treatment and for the same reason as the toolbar above it. No new types, no layout restructuring, no resource strings — the existing margins already give the wrapped row the spacing the toolbar uses.Verified
Release build clean; the
.vsixstill ships zero Roslyn/TestWindow DLLs and keepszh-Hans/ClaudeCodeVS.resources.dll.Ran it in the experimental hive on 18.9.12105.275 (VS 2026), panel floating so I could drive the width directly:
PasteandComposewrap to line 2, both fully visible and inside the card. Before the change,Composewas cut by the card edge at this width.PasteandComposeall on one line. No gratuitous wrapping when there is room.The horizontal scrollbar still visible at the bottom of the panel belongs to the ACTIVITY feed (long log lines, deliberately not wrapped) — that one is pre-existing and correct.
🤖 Generated with Claude Code