Repository navigation
Add rel=noopener noreferrer to card and issue external links - #772
Open
GuillermoBarreto wants to merge 1 commit into
Open
GuillermoBarreto wants to merge 1 commit into
GuillermoBarreto wants to merge 1 commit into
Conversation
The target=_blank anchors in ProjectCard.astro and IssueList.astro opened external pages without rel attributes, leaving the site open to reverse tabnabbing. The nav bar and social share components already use rel=noopener noreferrer; this makes the card links consistent with them.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
target="_blank"anchors insrc/components/ProjectCard.astro(the card link wrapper and the "Go to Project" button) andsrc/components/IssueList.astro(issue links) now includerel="noopener noreferrer".Why
Opening external pages without
relontarget="_blank"links leaves the page open to reverse tabnabbing (the opened page can accesswindow.opener). The Navbar and SocialShare components already userel="noopener noreferrer"on their external links, so this makes the card and issue links consistent with the rest of the site.No visual change; link behavior is unchanged apart from the security hardening.