Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mission-control/blog/control-plane-testing/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ To follow this tutorial, you need:

Before you can create a canary you should start with a working example of a resource, in this example we use a `HelmRelease` to deploy a postgres database.

```yaml file=flux.yaml
```yaml title="flux.yaml" file=./flux.yaml
```

Once you have verified the helm release is working on its own, you can then begin building the control plane test using `canary-checker`.
Expand All @@ -85,13 +85,13 @@ To follow this tutorial, you need:
This tutorial uses the CLI for faster feedback, in production we recommend installing `canary-checker` as an operator using the [helm chart](https://canarychecker.io/getting-started) or as part of the full Mission Control [platform](/docs/installation/self-hosted).
1. Next create a `Canary` CustomResourceDefinition (CRD) using the `kubernetesResource` check type, the layout of the canary is as follows:

```yaml title=basic-canary.yaml file=template.yaml
```yaml title="basic-canary.yaml" file=./template.yaml
```
<p/>

Using the workload defined in step 1, the check definition is as follows:

```yaml title=basic-canary.yaml file=basic-canary.yaml
```yaml title="basic-canary.yaml" file=./basic-canary.yaml
```
<p/>

Expand Down Expand Up @@ -183,7 +183,7 @@ To follow this tutorial, you need:
3. The final test looks like:


```yaml file=custom-canary.yaml
```yaml title="custom-canary.yaml" file=./custom-canary.yaml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Fix inconsistent indentation of the custom-canary.yaml code block.

Line 186 has 3 spaces of indentation ( ```yaml) while the earlier code blocks (lines 74, 88, 94) use 4 spaces. This breaks the consistent markdown list formatting. According to coding guidelines, YAML code blocks should be properly indented as part of their enclosing structure.

📝 Proposed fix for indentation
-   ```yaml title="custom-canary.yaml" file=./custom-canary.yaml
+    ```yaml title="custom-canary.yaml" file=./custom-canary.yaml
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@mission-control/blog/control-plane-testing/index.mdx` at line 186, The code
block containing the custom-canary.yaml file reference on line 186 has
inconsistent indentation with only 3 spaces instead of the 4 spaces used in the
earlier code blocks on lines 74, 88, and 94. Change the indentation of the
markdown code block (```yaml title="custom-canary.yaml"
file=./custom-canary.yaml) from 3 spaces to 4 spaces to maintain consistent list
formatting and follow the established indentation pattern in the document.

Source: Coding guidelines

```

## Conclusion
Expand Down
1 change: 1 addition & 0 deletions mission-control/docusaurus.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ export default async function createConfigAsync() {
blog: {
showReadingTime: true,
blogTitle: 'Flanksource Blog',
remarkPlugins: [codeImport],
// blogDescription: 'A Docusaurus powered blog!',
postsPerPage: 'ALL',
blogSidebarTitle: 'All posts',
Expand Down
2 changes: 1 addition & 1 deletion modules/canary-checker
Submodule canary-checker updated 101 files
2 changes: 1 addition & 1 deletion modules/config-db
Submodule config-db updated 428 files
2 changes: 1 addition & 1 deletion modules/duty
Submodule duty updated 329 files
2 changes: 1 addition & 1 deletion modules/mission-control
Submodule mission-control updated 663 files
2 changes: 1 addition & 1 deletion modules/mission-control-chart
Submodule mission-control-chart updated 77 files
+7 −12 .github/workflows/agent-test.yml
+0 −68 .github/workflows/bump-chart-deps.yml
+0 −20 .github/workflows/kratos-migration-test.yml
+5 −39 .github/workflows/release.yml
+8 −27 .github/workflows/test.yml
+1 −2 .gitignore
+6 −12 Makefile
+3 −3 agent-chart/Chart.yaml
+4 −11 agent-chart/README.md
+0 −25 agent-chart/templates/auth-secret.yaml
+0 −19 agent-chart/templates/deployment.yaml
+1 −81 agent-chart/values.schema.json
+1 −12 agent-chart/values.yaml
+2 −1 chart/.helmignore
+7 −7 chart/Chart.lock
+5 −5 chart/Chart.yaml
+7 −25 chart/README.md
+0 −86 chart/crds/mission-control.flanksource.com_applications.yaml
+33 −991 chart/crds/mission-control.flanksource.com_connections.yaml
+0 −60 chart/crds/mission-control.flanksource.com_incidentrules.yaml
+2 −363 chart/crds/mission-control.flanksource.com_notifications.yaml
+1 −61 chart/crds/mission-control.flanksource.com_notificationsilences.yaml
+0 −60 chart/crds/mission-control.flanksource.com_permissiongroups.yaml
+0 −73 chart/crds/mission-control.flanksource.com_permissions.yaml
+71 −1,164 chart/crds/mission-control.flanksource.com_playbooks.yaml
+0 −248 chart/crds/mission-control.flanksource.com_plugins.yaml
+0 −461 chart/crds/mission-control.flanksource.com_views.yaml
+1 −30 chart/templates/_helpers.tpl
+0 −25 chart/templates/artifactstore/connection.yaml
+0 −64 chart/templates/artifactstore/deployment.yaml
+0 −19 chart/templates/artifactstore/pvc.yaml
+0 −23 chart/templates/artifactstore/secret.yaml
+0 −20 chart/templates/artifactstore/service.yaml
+1 −1 chart/templates/cleanup-job.yaml
+1 −12 chart/templates/deployment.yaml
+0 −7 chart/templates/permissions/all-users.yaml
+0 −14 chart/templates/permissions/mcp.yaml
+1 −1 chart/templates/permissions/system.yaml
+29 −1 chart/templates/pgbouncer.yaml
+1 −4 chart/templates/rbac.yaml
+1 −1 chart/templates/secrets.yaml
+1 −2 chart/templates/service.yaml
+1 −1 chart/templates/servicemonitor.yaml
+33 −0 chart/templates/views/dashboard/dashboard.yaml
+0 −51 chart/templates/views/system/database.yaml
+2 −2 chart/templates/views/system/job_history.yaml
+0 −7 chart/templates/views/system/system.yaml
+10 −57 chart/test/basic_test.go
+17 −27 chart/test/go.mod
+26 −42 chart/test/go.sum
+0 −257 chart/test/kratos_test.go
+3 −14 chart/test/mission-control.go
+2 −0 chart/test/suite_test.go
+1 −112 chart/test/utils_test.go
+2 −213 chart/values.schema.json
+3 −59 chart/values.yaml
+3 −72 crd-chart/templates/canary-checker.flanksource.com_Canary.yaml
+0 −43 crd-chart/templates/canary-checker.flanksource.com_Topology.yaml
+211 −3,082 crd-chart/templates/configs.flanksource.com_scrapeconfigs.yaml
+5 −120 crd-chart/templates/configs.flanksource.com_scrapeplugins.yaml
+0 −86 crd-chart/templates/mission-control.flanksource.com_applications.yaml
+33 −991 crd-chart/templates/mission-control.flanksource.com_connections.yaml
+0 −60 crd-chart/templates/mission-control.flanksource.com_incidentrules.yaml
+2 −363 crd-chart/templates/mission-control.flanksource.com_notifications.yaml
+1 −61 crd-chart/templates/mission-control.flanksource.com_notificationsilences.yaml
+0 −60 crd-chart/templates/mission-control.flanksource.com_permissiongroups.yaml
+0 −73 crd-chart/templates/mission-control.flanksource.com_permissions.yaml
+71 −1,164 crd-chart/templates/mission-control.flanksource.com_playbooks.yaml
+0 −248 crd-chart/templates/mission-control.flanksource.com_plugins.yaml
+0 −461 crd-chart/templates/mission-control.flanksource.com_views.yaml
+0 −41 scripts/mirror-images.sh
+0 −167 scripts/wait-for-charts.sh
+0 −42 test/kratos-migration/docker-compose.yml
+0 −34 test/kratos-migration/identity-schema.json
+0 −43 test/kratos-migration/kratos-config.yaml
+0 −173 test/kratos-migration/test.sh
+1 −1 test/test.sh
2 changes: 1 addition & 1 deletion modules/mission-control-registry
Submodule mission-control-registry updated 34 files
+0 −98 .github/workflows/manual-test.yml
+1 −1 charts/misc-playbooks/Chart.yaml
+1 −1 charts/mission-control/Chart.yaml
+1 −1 charts/mission-control/templates/NOTES.txt
+768 −0 charts/mission-control/templates/topology.yaml
+8 −11 charts/mission-control/values.schema.json
+7 −13 charts/mission-control/values.yaml
+1 −1 charts/mongo-atlas/Chart.yaml
+3 −28 charts/mongo-atlas/templates/scraper.yaml
+1 −1 charts/mssql/Chart.yaml
+98 −94 charts/mssql/README.md
+0 −84 charts/mssql/README.md.tpl
+0 −84 charts/mssql/conf/copy-tables.sql
+0 −15 charts/mssql/conf/drop-restore-db.sql
+100 −24 charts/mssql/conf/grant-db-access.sql
+13 −73 charts/mssql/conf/kill-long-running-transactions.sql
+4 −42 charts/mssql/conf/list-long-running-transactions.sql
+0 −98 charts/mssql/conf/rds-restore-backup.sql
+1 −1 charts/mssql/conf/rds-tasks.sql
+63 −34 charts/mssql/conf/revoke-db-access.sql
+0 −63 charts/mssql/conf/s3-bucket-scraper.py
+0 −35 charts/mssql/templates/backup-scraper.yaml
+1 −1 charts/mssql/templates/playbooks/create-login-user.yaml
+14 −17 charts/mssql/templates/playbooks/grant-mssql-user-db-access.yaml
+0 −47 charts/mssql/templates/playbooks/restore-tables.yaml
+182 −135 charts/mssql/values.schema.json
+1 −17 charts/mssql/values.yaml
+0 −58 charts/playbooks-misc/templates/delete-config-item.yaml
+0 −37 charts/playbooks-misc/templates/delete-scraped-resources.yaml
+0 −68 charts/playbooks-misc/templates/delete-scraper.yaml
+0 −185 charts/playbooks-misc/templates/run-scraper.yaml
+0 −110 charts/playbooks-misc/templates/update-logging-levels.yaml
+0 −74 charts/playbooks-misc/values.schema.json
+0 −12 charts/playbooks-misc/values.yaml
Loading