[2.x] fix(audit): remove circular optional-dependencies on first-party extensions#4712
Merged
Conversation
…y extensions When the first-party audit integrations moved into their respective extensions, those extensions began declaring flarum/audit as an optional dependency. Audit still listed them in turn, creating a dependency cycle that aborts the extension loader. Audit no longer references those extensions at boot, so drop them from its optional-dependencies; fof/geoip stays (one-way, render-time integration, no cycle).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a circular dependency that aborts the extension loader:
When the first-party audit integrations moved into their respective extensions (#4711), those extensions began declaring
flarum/auditas anoptional-dependency. Audit still listed them in turn, so eachaudit ↔ <extension>pair formed a cycle.Audit no longer references those extensions at boot — every integration now flows the other way (extension → audit). This removes the seven first-party entries from audit's
optional-dependencies.fof/geoipstays: it's a one-way, render-time integration (it enhances core's IP address component) and does not depend back on audit, so it isn't part of a cycle.Verified the resulting optional-dependency graph across the affected extensions is acyclic.