attested-tls should use the new sync verifier method rather than the async one with block_in_place#35
Merged
Merged
Conversation
…iled verification
Co-authored-by: Anton <anton@northernforest.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches attested-tls certificate verification to use the synchronous attestation verifier rather than using
tokio::block_in_placeto run the async version.It includes a test which demonstrates that when certification verification fails due to missing collateral in the PCCS, we can wait a moment and re-try, as the PCCS will immediately fetch the missing collateral when this happens. The unmerged 'mock-pck' crate is needed for that, so this PR targets #29
Edit: This is actually now already done in #20 but i think its still worth merging this to have a test covering it.