Skip to content

Add scenario access list support#581

Open
karlfloersch wants to merge 4 commits into
flashbots:mainfrom
karlfloersch:scenario-access-list-support
Open

Add scenario access list support#581
karlfloersch wants to merge 4 commits into
flashbots:mainfrom
karlfloersch:scenario-access-list-support

Conversation

@karlfloersch
Copy link
Copy Markdown

@karlfloersch karlfloersch commented May 12, 2026

Summary

⚠️ AI generated code

Adds first-class EIP-2930 access-list entries to scenario-generated transaction requests. Scenario authors can now specify [[spam.tx.access_list]] entries with an address and storage keys, and Contender threads those entries into Alloy TransactionRequest.access_list.

The implementation keeps access lists generic and compatible with EIP-1559 transaction completion.

Validation

  • cargo +1.94.0 fmt --check
  • cargo +1.94.0 test -p contender_core access_list --lib
  • cargo +1.94.0 test -p contender_testfile access_list --lib
  • cargo +1.94.0 test -p contender_testfile --lib

Note: cargo +1.94.0 test -p contender_core --lib was also run and had 36 passing tests with 4 existing Anvil/provider-style failures unrelated to this change.

Copy link
Copy Markdown
Member

@zeroXbrock zeroXbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @karlfloersch!

Comment thread crates/core/src/generator/function_def.rs Outdated
@karlfloersch karlfloersch marked this pull request as ready for review May 12, 2026 22:47
Copy link
Copy Markdown
Member

@zeroXbrock zeroXbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @karlfloersch!

@karlfloersch
Copy link
Copy Markdown
Author

Thank you!

@karlfloersch
Copy link
Copy Markdown
Author

I should have mentioned this earlier:

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

THIS CODE WAS AI GENERATED (5.5 high fwiw)

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

@zeroXbrock
Copy link
Copy Markdown
Member

I should have mentioned this earlier:

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

THIS CODE WAS AI GENERATED (5.5 high fwiw)

⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️⚠️

😂 no problem, all code is welcome here.
Approving optimistically -- code looks good, but I still need to test it myself before merging. Running out of time to do so today, but I'll have time tomorrow to wrap this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants