systemd: Escape %s in oem-cloudinit.service - #146
Merged
Conversation
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, localized, and correct for systemd unit file % escaping semantics, with no apparent side effects.
Pull request overview
This PR fixes a systemd unit escaping issue so the ExecStart command passes the intended printf format string (%s) to the shell instead of being interpreted as a systemd specifier.
Changes:
- Escape the
%inprintf "%s"asprintf "%%s"withinoem-cloudinit.serviceto avoid systemd specifier expansion.
File summaries
| File | Description |
|---|---|
| systemd/system/oem-cloudinit.service | Escapes % in the printf format string to ensure correct runtime behavior under systemd. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tormath1
approved these changes
Sep 4, 2026
tormath1
left a comment
tormath1
left a comment
Contributor
There was a problem hiding this comment.
Copilot is curiously silent on this one.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot made a bad suggestion in #145. I had previously tested this with
echorather thanprintf. I haven't tested this change, but it can't make things any worse.