Repository navigation
Avoid repeated Hilbert transforms in matrix convolution - #23
Merged
Merged
Conversation
Collaborator
|
Great catch @HugoStrand. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matrix-valued
imtime_ops::convolverecomputes both complete Hilberttransforms inside the DLR-index loop. Compute each transform once before the
loop and reuse its slices, reducing full-array transform calls from
2rto2for both ordinary and time-ordered convolution. The API and matrix-product
order are unchanged.
Validation: Release build with Clang 19; all 12 CTest entries pass. Existing
convolution tests cover real/complex and square/rectangular matrices against
analytic results and the independent
convmatimplementation.