Repository navigation
fix: draw polygons that reach behind the camera - #2292
Open
greensopinion wants to merge 1 commit into
Open
greensopinion wants to merge 1 commit into
greensopinion wants to merge 1 commit into
Conversation
Flutter 3.27 draws nothing of a polygon with a vertex behind the camera, so on a pitched map such a polygon disappeared. The polygon painter now clips polygons to the ground in front of the camera before filling them; the edges that the clip adds are below the map view. Newer Flutter releases already drew these polygons, and polygons in front of the camera and unpitched maps don't change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flutter 3.27 draws nothing of a polygon with a vertex behind the camera,
so on a pitched map such a polygon disappeared. The polygon painter now
clips polygons to the ground in front of the camera before filling them;
the edges that the clip adds are below the map view. Newer Flutter
releases already drew these polygons, and polygons in front of the
camera and unpitched maps don't change.
Depends on #2291.
I wrote this with Claude Code (Claude Opus 5.5). I directed the design,
reviewed the code, and tested it on Flutter 3.27.0 and the current
release.