fix(flow-php/telemetry-otlp-bridge): push async curl transport in long-running worker#2467
Merged
Conversation
…g-running worker - add non-blocking CurlTransport::tick() to drive in-flight requests - push curl transports on Messenger WorkerRunningEvent with tick() - raise curl per-request timeout_ms default 250 -> 5000 - surface export failures to ErrorHandler as reaped instead of unbounded retain
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2467 +/- ##
============================================
- Coverage 85.13% 85.13% -0.01%
- Complexity 0 21328 +21328
============================================
Files 1609 1610 +1
Lines 65763 65786 +23
============================================
+ Hits 55988 56006 +18
- Misses 9775 9780 +5 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/telemetry-otlp-bridge- non-blockingCurlTransport::tick()to drive in-flight requestsflow-php/symfony-telemetry-bundle- pump curl transports on MessengerWorkerRunningEventFixed
flow-php/telemetry-otlp-bridge- telemetry lost in long-running workers when requests stalled between messagesflow-php/telemetry-otlp-bridge- unbounded failure accumulation by surfacing export failures to the ErrorHandler as reapedChanged
flow-php/telemetry-otlp-bridge- curl per-requesttimeout_msdefault raised 250 to 5000Removed
Deprecated
Security