in_prometheus: do not disclosure error details for client - #259
Open
kenhys wants to merge 1 commit into
Open
Conversation
It is reasonable to logging error, but no need to disclose detail for client. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
changed the title
Watson1978
reviewed
Jul 31, 2026
| response(::Prometheus::Client::Formats::Text.marshal(@registry)) | ||
| rescue => e | ||
| [500, { 'Content-Type' => 'text/plain' }, e.to_s] | ||
| log.error "in_prometheus: failed to render metrics", error_class: e.class, error: e |
Contributor
There was a problem hiding this comment.
all_metrics runs on every scrape, so if the failure is persistent, this will log an error on every scrape interval (15s by default in Prometheus).
That's a behavior change from before, when the failure was silent on the server side.
This is probably acceptable, and Fluentd's ignore_same_log_interval system config can mitigate it if needed.
Contributor
Author
There was a problem hiding this comment.
Hmm, surely that behavior might be bad. I'll think about it for a bit.
Watson1978
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is reasonable to logging error, but no need to disclose detail for client.