Fix parameter type, default value#638
Open
Watson1978 wants to merge 7 commits into
Open
Conversation
The default value was changed at fluent/fluentd#1311 Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
The rate_period was introduced at fluent/fluentd#3535. The default value was 5 from the beginning. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
The backlog parameter was introduced at fluent/fluentd@48b5173 Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
The proto parameter was introduced at fluent/fluentd@adb82fb Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
changed the title
kenhys
requested changes
Jul 23, 2026
| | type | default | version | | ||
| | :--- | :--- | :--- | | ||
| | bool | false | 0.14.0 | | ||
| | bool | true | 0.14.0 | |
Contributor
There was a problem hiding this comment.
Suggested change
| | bool | true | 0.14.0 | | |
| | bool | true | 0.14.9 | |
ref.
gg auto_typecast G config_param | \grep -E "0\.14\.(10|[7-9])"
fluentd-0.14.10/lib/fluent/plugin/filter_record_transformer.rb: config_param :auto_typecast, :bool, default: true
fluentd-0.14.9/lib/fluent/plugin/filter_record_transformer.rb: config_param :auto_typecast, :bool, default: true
fluentd-0.14.7/lib/fluent/plugin/filter_record_transformer.rb: config_param :auto_typecast, :bool, default: false # false for lower version compatibility
fluentd-0.14.8/lib/fluent/plugin/filter_record_transformer.rb: config_param :auto_typecast, :bool, default: false # false for lower version compatibility
| | type | default | version | | ||
| | :--- | :--- | :--- | | ||
| | size | 10 \(seconds\) | 0.14.0 | | ||
| | time | 10 \(seconds\) | 0.14.0 | |
Contributor
There was a problem hiding this comment.
Fix it self is LGTM, but version seems incorrect.
(It seems that supported since 0.10.0)
| | type | default | version | | ||
| | :--- | :--- | :--- | | ||
| | integer | 60 | 0.14.0 | | ||
| | time | 60 | 0.14.0 | |
Contributor
There was a problem hiding this comment.
Suggested change
| | time | 60 | 0.14.0 | | |
| | time | 60 | 0.12.17 | |
gg emit_interval G config_param|sort G monitor
fluentd-0.12.17/lib/fluent/plugin/in_monitor_agent.rb: config_param :emit_interval, :time, :default => 60
fluentd-0.12.18/lib/fluent/plugin/in_monitor_agent.rb: config_param :emit_interval, :time, :default => 60
fluentd-0.12.19/lib/fluent/plugin/in_monitor_agent.rb: config_param :emit_interval, :time, :default => 60
fluentd-0.12.20/lib/fluent/plugin/in_monitor_agent.rb: config_param :emit_interval, :time, :default => 60
| | type | default | version | | ||
| | :--- | :--- | :--- | | ||
| | time | 60 \(seconds\) | 1.15 | | ||
| | time | 5 \(seconds\) | 1.15 | |
Contributor
There was a problem hiding this comment.
Suggested change
| | time | 5 \(seconds\) | 1.15 | | |
| | time | 5 \(seconds\) | 1.15.0 | |
| | type | default | version | | ||
| | :---: | :---: | :---: | | ||
| | integer | 1024 | 0.14.0 | | ||
| | integer | nil | 0.14.0 | |
Contributor
There was a problem hiding this comment.
Suggested change
| | integer | nil | 0.14.0 | | |
| | integer | nil | 0.14.1 | |
No in_unix for 0.14.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix the default values of configuration parameter, or parameter types.